[p4] Review Emails Not Sent

[P4Matt]

Posted on behalf of forum user 'P4Matt'.

To have reviews sent out you'll also need to setup a review script to
generate and fire off the messages. My current favorite was written by one of
our support folks:

https://swarm.workshop.perforce.com/projects/lester-cheung-p4review

Here's the installation readme:
https://swarm.workshop.perforce.com/projects/lester-cheung-p4review/files/main/p4review2.readme.txt

Here's the script itself:
https://swarm.workshop.perforce.com/projects/lester-cheung-p4review/files/main/p4review2.py



--
Please click here to see the post in its original format:
http://forums.perforce.com/index.php?/topic/3273-review-emails-not-sent

[Jason C]

Posted on behalf of forum user 'Jason C'.

Thanks, Matt!



--
Please click here to see the post in its original format:
http://forums.perforce.com/index.php?/topic/3273-review-emails-not-sent

[Lennart Kjellén]

Posted on behalf of forum user 'Lennart Kjellén'.

The review feature is well integrated in both documentation and appropriate
client software. It is reasonable to expect also sending of emails to be
integrated in server software. Why is it designed so that you need a separate
script for this?



--
Please click here to see the post in its original format:
http://forums.perforce.com/index.php?/topic/3273-review-emails-not-sent

[P4Matt]

Posted on behalf of forum user 'P4Matt'.

When Perforce was first written many moons ago (1995!) portability was one
of its number one goals. My understanding is there was enough variability in
email handling across OSs that it was decided it made more sense to make it easy
to get the review information and then push the actual email server interaction
out to something that could be easily modified for any platform.

For people using Swarm, our collaboration tool, review email is entirely handled
by that application, including activity notification.



--
Please click here to see the post in its original format:
http://forums.perforce.com/index.php?/topic/3273-review-emails-not-sent

[Jason C]

Posted on behalf of forum user 'Jason C'.

I am probably being dumb, but what is likely the cause of this?

2014-05-09 10:19 INFO App (pid=10771) initiated. 2014-05-09 10:19 INFO Review
counter (review): 258 2014-05-09 10:19 INFO Scraping for change review...
2014-05-09 10:19 INFO 1 change review(s). 2014-05-09 10:19 INFO 0 job review(s).
2014-05-09 10:19 CRITICAL <type 'exceptions.TypeError'> 2014-05-09
10:19 CRITICAL character mapping must return integer, None or unicode 2014-05-09
10:19 CRITICAL File "p4review2.py", line 1284, in <module> rv =
app.run() 2014-05-09 10:19 CRITICAL File "p4review2.py", line 1213, in
run self.send_one_email_per_change()
(feel free to bump me to another thread/topic)



--
Please click here to see the post in its original format:
http://forums.perforce.com/index.php?/topic/3273-review-emails-not-sent

[P4Lester]

Posted on behalf of forum user 'P4Lester'.

Let me guess - are using Python 3.x? You will need Python 2.7.

I need to update the script so that it works with Python3 at some point....



--
Please click here to see the post in its original format:
http://forums.perforce.com/index.php?/topic/3273-review-emails-not-sent